Skip to content

Juanvqz/change json to yaml format #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Juanvqz/change json to yaml format #88

wants to merge 4 commits into from

Conversation

JuanVqz
Copy link

@JuanVqz JuanVqz commented Sep 27, 2020

Fixes

Fixes #85 by @dhruvkb

Description

change JSON to YAML format

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@JuanVqz
Copy link
Author

JuanVqz commented Sep 27, 2020

@dhruvkb I didn't find the corresponding \uD83D\uDFE5 emoji code in this cheat sheet.
What should I do?

@dhruvkb
Copy link
Member

dhruvkb commented Sep 27, 2020

@JuanVqz please leave them as codepoints for now. We can find replacements for them later.

@JuanVqz JuanVqz changed the title WIP Juanvqz/change json to yaml format Juanvqz/change json to yaml format Sep 27, 2020
@JuanVqz
Copy link
Author

JuanVqz commented Sep 27, 2020

@dhruvkb Would you check it, please? I think it is finished.

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the few changes pointed below, this is great work! However you will also need to make the corresponding changes to the Python code in get_labels.py that reads and interprets these files as that has been written for the JSON format.

@@ -0,0 +1,133 @@
groups:
group:
name: "priority"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values that are plain strings do not need to be surrounded in quotes.

name: "blocked"
color: "MEDIUM"
description: "Blocked & therefore, not ready for work"
emoji: "\uD83D\uDEA7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace emojis that are present in the cheat sheet with the colon-representation. Only leave those that are absent as codepoints.

Suggested change
emoji: "\uD83D\uDEA7"
emoji: ":construction:"

@JuanVqz JuanVqz closed this Oct 7, 2020
@JuanVqz
Copy link
Author

JuanVqz commented Oct 7, 2020

I don't know why the PR repo says unknown repository that is the reason I open another PR #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase readability of label data files
2 participants