-
Notifications
You must be signed in to change notification settings - Fork 18
Juanvqz/change json to yaml format #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Juanvqz/change json to yaml format #88
Conversation
@dhruvkb I didn't find the corresponding |
@JuanVqz please leave them as codepoints for now. We can find replacements for them later. |
@dhruvkb Would you check it, please? I think it is finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the few changes pointed below, this is great work! However you will also need to make the corresponding changes to the Python code in get_labels.py
that reads and interprets these files as that has been written for the JSON format.
@@ -0,0 +1,133 @@ | |||
groups: | |||
group: | |||
name: "priority" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Values that are plain strings do not need to be surrounded in quotes.
name: "blocked" | ||
color: "MEDIUM" | ||
description: "Blocked & therefore, not ready for work" | ||
emoji: "\uD83D\uDEA7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace emojis that are present in the cheat sheet with the colon-representation. Only leave those that are absent as codepoints.
emoji: "\uD83D\uDEA7" | |
emoji: ":construction:" |
I don't know why the PR repo says unknown repository that is the reason I open another PR #93 |
Fixes
Fixes #85 by @dhruvkb
Description
change JSON to YAML format
Technical details
Tests
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin