Skip to content

Fix or improve styling for active nav links when navbar has collapsed. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
kgodey opened this issue Mar 7, 2019 · 3 comments · Fixed by #28
Closed
1 task done

Fix or improve styling for active nav links when navbar has collapsed. #25

kgodey opened this issue Mar 7, 2019 · 3 comments · Fixed by #28
Labels
good first issue New-contributor friendly help wanted Open to participation from the community

Comments

@kgodey
Copy link
Member

kgodey commented Mar 7, 2019

I'm submitting a...

  • Bug

Description:
The styling for the active nav item looks fine when the nav is expanded (see blue box in screenshot)
active link full size

When the nav is collapsed, the border beneath the active item occupies the entire width of the header.
active link collapsed

Feel free to change the active link styling if desired. One way to fix it may be to use similar styling to the https://creativecommons.org website (see "Use & remix" nav styling in https://creativecommons.org/use-remix/).
@kgodey kgodey added help wanted Open to participation from the community good first issue New-contributor friendly labels Mar 7, 2019
@makkoncept
Copy link
Member

hi @kgodey, can I work on this issue?

Thanks

@kgodey kgodey mentioned this issue Mar 7, 2019
Merged
3 tasks
hugosolar added a commit that referenced this issue Mar 8, 2019
@hugosolar
Merge pull request #28 from makkoncept/master
4eb025e 
[Fix] improve styling for active nav links when navbar has collapsed.#25
@kgodey
Copy link
Member Author

kgodey commented Mar 8, 2019

The media query was missing an end curly brace and broke the ToC styling, I fixed it in 1558da3

Screen Shot 2019-03-08 at 3 59 00 PM

@makkoncept
Copy link
Member

Sorry I didn't noticed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue New-contributor friendly help wanted Open to participation from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] improve styling for active nav links when navbar has collapsed.#25
2 participants
@kgodey @makkoncept