Skip to content

Conversation

@Dhruvi16
Copy link
Member

@Dhruvi16 Dhruvi16 commented Jul 4, 2020

Description

This updates all authors page according to the mockup.

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Dhruvi16 Dhruvi16 requested review from a team, akmadian, dhruvkb and hugosolar and removed request for a team and akmadian July 4, 2020 16:19
Copy link
Contributor

@hugosolar hugosolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great but on phone screens, I think we can use 2 columns instead just one. Take a look at Columns responsiveness on Bulma's documentation

Screen Shot 2020-07-06 at 5 02 42 PM

@Dhruvi16
Copy link
Member Author

Dhruvi16 commented Jul 7, 2020

I tried it but I think this might happen -
image

@hugosolar
Copy link
Contributor

I tried it but I think this might happen -
image

Maybe the size of the names can be decreased?

@Dhruvi16
Copy link
Member Author

Dhruvi16 commented Jul 7, 2020

I tried it but I think this might happen -
image

Maybe the size of the names can be decreased?

You are suggesting to alter font size?

@hugosolar
Copy link
Contributor

I tried it but I think this might happen -
image

Maybe the size of the names can be decreased?

You are suggesting to alter font size?

Just in the phone screen size

@Dhruvi16
Copy link
Member Author

Dhruvi16 commented Jul 7, 2020

Okay will do it.

@Dhruvi16
Copy link
Member Author

Dhruvi16 commented Jul 7, 2020

Updated @hugosolar

@hugosolar hugosolar self-assigned this Jul 7, 2020
Copy link
Contributor

@hugosolar hugosolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! now it looks better on mobile. well done

@Dhruvi16 Dhruvi16 merged commit a8f165f into add_vocabulary Jul 8, 2020
@Dhruvi16 Dhruvi16 deleted the add_all_authors branch July 8, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants