Skip to content

Webpack updates #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 9, 2021
Merged

Webpack updates #607

merged 12 commits into from
Mar 9, 2021

Conversation

TimidRobot
Copy link
Member

@TimidRobot TimidRobot commented Mar 9, 2021

Description

Update node/npm packages to most recent working versions.

I significantly simplified package.json since it is private (will never be published for others to use) and used jq to format it (jq -SM '.' package.json > NEW; mv NEW package.json)

Warnings before changes:

npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated core-js@2.6.12: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

Warnings after changes:

npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated core-js@2.6.12: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

Upgrade/Migration Notes

  • https://webpack.js.org/migrate/5/
     BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
     This is no longer the case. Verify if you need this module and configure a polyfill for it.
     
     If you want to include a polyfill, you need to:
     	- add a fallback 'resolve.fallback: { "buffer": require.resolve("buffer/") }'
     	- install 'buffer'
     If you don't want to include a polyfill, you can use an empty module like this:
     	resolve.fallback: { "buffer": false }
    
  • https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users

Issues Encountered

  • Could not update js-yaml from 3.14.1 to 4.0.0 as it broke /contributing-code/issue-finder/. The filters never loaded leaving the "Loading filters, please wait..." message.
  • Could not update @creativecommons/vocabulary from 2020.11.1 to 2020.11.3 or later. The navigation menus disappeared.

Tests

I used /contributing-code/issue-finder/ (Issue Finder — Creative Commons Open Source) to verify that nothing broke. I am not aware of any other pages with custom/specific JavaScript.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

- pin vocabulary to 2020.11.1
  - MORE RECENT VERSIONS BREAK NAV
- add private:true to ensure webpack config is not accidentally
  published
- removed optional (and redundant since it is not published) items
NOTE: "js-yaml": "^4.0.0", breaks /contributing-code/issue-finder/
NOTE: there is not currently a stable version of vue-select that
supports vue 3.x
- https://webpack.js.org/migrate/5/
    ```
    BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
    This is no longer the case. Verify if you need this module and configure a polyfill for it.

    If you want to include a polyfill, you need to:
            - add a fallback 'resolve.fallback: { "buffer": require.resolve("buffer/") }'
            - install 'buffer'
    If you don't want to include a polyfill, you can use an empty module like this:
            resolve.fallback: { "buffer": false }
    ```
- https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users
@TimidRobot TimidRobot requested review from annatuma and zackkrida March 9, 2021 16:59
@TimidRobot TimidRobot requested a review from a team as a code owner March 9, 2021 16:59
@TimidRobot TimidRobot self-assigned this Mar 9, 2021
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one small suggestion to further simplify the package.json

@TimidRobot TimidRobot merged commit c671846 into master Mar 9, 2021
@TimidRobot TimidRobot deleted the webpack-updates branch March 9, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants