-
-
Notifications
You must be signed in to change notification settings - Fork 185
Webpack updates #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Webpack updates #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pin vocabulary to 2020.11.1 - MORE RECENT VERSIONS BREAK NAV - add private:true to ensure webpack config is not accidentally published - removed optional (and redundant since it is not published) items
NOTE: "js-yaml": "^4.0.0", breaks /contributing-code/issue-finder/
NOTE: there is not currently a stable version of vue-select that supports vue 3.x
- https://webpack.js.org/migrate/5/ ``` BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. This is no longer the case. Verify if you need this module and configure a polyfill for it. If you want to include a polyfill, you need to: - add a fallback 'resolve.fallback: { "buffer": require.resolve("buffer/") }' - install 'buffer' If you don't want to include a polyfill, you can use an empty module like this: resolve.fallback: { "buffer": false } ``` - https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users
zackkrida
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left one small suggestion to further simplify the package.json
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update node/npm packages to most recent working versions.
I significantly simplified
package.json
since it is private (will never be published for others to use) and usedjq
to format it (jq -SM '.' package.json > NEW; mv NEW package.json
)Warnings before changes:
Warnings after changes:
Upgrade/Migration Notes
Issues Encountered
js-yaml
from3.14.1
to4.0.0
as it broke/contributing-code/issue-finder/
. The filters never loaded leaving the "Loading filters, please wait..." message.@creativecommons/vocabulary
from2020.11.1
to2020.11.3
or later. The navigation menus disappeared.Tests
I used
/contributing-code/issue-finder/
(Issue Finder — Creative Commons Open Source) to verify that nothing broke. I am not aware of any other pages with custom/specific JavaScript.Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin