Add unit tests for license-uitilities.js

[akmadian]

Unit tests need to be written for license-utilities.js. Unit tests are done with Jest.

Please remember to test the following things:

• All methods, being sure to test a range of inputs for each method, including edge cases.

Additional Context

• ./src/utils/license-utilities.js
• This repo's testing README
• Vue's guide on unit testing
• Vue's guide on unit testing with VueX

[acagastya]

Hello. Could I work on the test coverages?

[akmadian]

Go ahead! @acagastya

[acagastya]

@akmadian Hi. Could you please tell me how to organise the tests? In which directory am I supposed to put it under?

[akmadian]

It should be organized similarly to how component tests are organized. Just like component unit tests go in ./tests/unit/specs/components/, unit test specs for utils should go in ./tests/unit/specs/utils/

[acagastya]

Okay, thank you. :-)
I have already started, and I will move it to the appropriate folder now.

[acagastya]

@akmadian While writing the tests, I just realised, the function attrToFull, which takes an object as a parameter, and outputs license string gives a wrong answer for this object: { BY: true, ND: true, SA: true }. Non-Deriv is mutually exclusive from ShareAlike. Right now, its result is Attribution-NonDerivatives 4.0 International (CC BY-ND 4.0).

Do we assume the parameters passed to the function will correspond to a valid license? Or should the function return an error?

[akmadian]

I think it's safe to assume that the ND and SA incompatability won't be an issue, the ability to make a selection for SA is disabled when ND is selected, so it's theoretically impossible for that specific configuration to get passed in.

So, to answer your question directly, it's safe to assume that the parameters passed will correspond to a valid license.

[acagastya]

Thank you for the swift response, @akmadian. I found another oddity.
attrToFull({ BY: undefined}) //? CC0 1.0 Universal
attrToShort({ BY: undefined}) //? undefined

Is that how they are supposed to behave?

[akmadian]

Thanks for catching this, I would say that for now, yes, this is expected behavior. The person who wrote this code is @obulat, and she's gonna be unavailable for a while, and I'm unsure if this is expected behavior.

Let's assume that this behavior is expected for now, and we can re-examine once @obulat is back :)