Skip to content

Bugs when copying information from the attribution box #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fcoveram opened this issue Nov 18, 2020 · 4 comments
Closed

Bugs when copying information from the attribution box #204

fcoveram opened this issue Nov 18, 2020 · 4 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@fcoveram
Copy link

Description

The rich text tab within attribution box has the following bugs:

  1. The links displayed are not copied correctly. It pastes a link mixed with the chooser link.
  2. The license icons are not copied correctly. When trying in a text editor, it does not paste the images.

Screenshots

Screen Shot 2020-11-18 at 09 45 52

@fcoveram fcoveram added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Nov 18, 2020
@Aspie96
Copy link
Contributor

Aspie96 commented Nov 30, 2020

Actually I tried it and it copies it correctly.

The link is correct except for the issue in #210 and the icons are copied (although they are too small if pasted on OpenOffice Writer for some reason).

@Aspie96
Copy link
Contributor

Aspie96 commented Nov 30, 2020

The reason for the size of the icons when pasted has to do with the "rem" unit of measurement.

If I change it to "em", writing in .attribution-tab .photo-license-icon "height: 1.4em" the icons appear of the exact same size as they currently do in the browser, but they become too large (instead of too small) in OpenOffice

@obulat
Copy link
Contributor

obulat commented Dec 2, 2020

The current version copies icons correctly to Word (I use WPS Office). Google Docs, however, shows image title (or alt text, I'm not sure) because it can't paste svg.

I've tinkered a little more with the copying of the rich text, and found a couple of things:

  1. The best way of making icon sizes consistent I found was to actually set the width and height of the img inline, as that gets respected in word-processing software.
  2. Google docs currently does not support pasting svg files as part of richtext. So, it is better to add license icons in png format and use them in richtext. HTML can still have svg links.

@obulat obulat mentioned this issue Dec 11, 2020
7 tasks
@obulat
Copy link
Contributor

obulat commented Jan 4, 2021

This issue has been solved by #252.

@obulat obulat closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants