-
-
Notifications
You must be signed in to change notification settings - Fork 180
Fix HTML generation error #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/components/LicenseDetailsCard.vue # tests/e2e/specs/AttributionDetailsStep.js # tests/e2e/specs/CopyrightWaiverStep.js # tests/unit/specs/components/CopyrightWaiverStep.spec.js # tests/unit/specs/components/LicenseText.spec.js # tests/unit/specs/components/__snapshots__/ChooserStep.spec.js.snap # tests/unit/specs/components/__snapshots__/LicenseDetailsCard.spec.js.snap
# Conflicts: # src/components/Stepper.vue # tests/unit/specs/components/__snapshots__/Stepper.spec.js.snap
# Conflicts: # package-lock.json # src/App.vue # src/components/HelpSection.vue # src/components/StepHeader.vue # src/components/Stepper.vue # src/locales/en.json # tests/unit/specs/components/HelpSection.spec.js
|
All of the changes introduced in this PR have actually already been merged as part of #252.. Here, I've added the changes to HTML generation to ensure that the generated HTML has the correct text. Previously, after we've changed the generated text for CC0 ('marked' instead of 'licensed'), the HTML generation has not been updated, and it was generating a phrase like 'This work CC BY' instead of 'This work has been licensed under CC BY' |
|
Closing this as the changes have already been merged. |
These changes have been merged as part of PR #252.
Fixes
Fixes #204 by @panchovm
Description
The chooser currently uses
.svgfiles in the richtext field for license attribution. When you copy the text and paste it, you get 2 outcomes:This work is licensed under CC BY-SA 4.0CC iconby iconsa icon)This PR enables users to copy and paste the richtext license attribution with the icon images.
Technical details
This fix is accomplished by removing the
titleandaltattributes from the license icon images to prevent pasting plain text and replacing SVG format with PNG format, which word processing apps can paste.This PR also cleans up the assets folder from unused files.
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin