Skip to content

Conversation

@obulat
Copy link
Contributor

@obulat obulat commented Dec 11, 2020

These changes have been merged as part of PR #252.

Fixes

Fixes #204 by @panchovm

Description

The chooser currently uses .svg files in the richtext field for license attribution. When you copy the text and paste it, you get 2 outcomes:

  • If you paste to a text editor, you get the text of the license icon titles (This work is licensed under CC BY-SA 4.0CC iconby iconsa icon)
  • If you paste it to a word processing application (I tried MS Word Online and Google docs), you get empty squares, because pasting SVG format is not supported.
    This PR enables users to copy and paste the richtext license attribution with the icon images.

Technical details

This fix is accomplished by removing the title and alt attributes from the license icon images to prevent pasting plain text and replacing SVG format with PNG format, which word processing apps can paste.
This PR also cleans up the assets folder from unused files.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

obulat added 18 commits December 6, 2020 13:24
# Conflicts:
#	src/components/LicenseDetailsCard.vue
#	tests/e2e/specs/AttributionDetailsStep.js
#	tests/e2e/specs/CopyrightWaiverStep.js
#	tests/unit/specs/components/CopyrightWaiverStep.spec.js
#	tests/unit/specs/components/LicenseText.spec.js
#	tests/unit/specs/components/__snapshots__/ChooserStep.spec.js.snap
#	tests/unit/specs/components/__snapshots__/LicenseDetailsCard.spec.js.snap
# Conflicts:
#	src/components/Stepper.vue
#	tests/unit/specs/components/__snapshots__/Stepper.spec.js.snap
@obulat obulat requested a review from a team as a code owner December 11, 2020 06:28
@obulat obulat requested review from akmadian and removed request for a team December 11, 2020 06:28
Failing due to account for scrolling delays and non-transformed png import
# Conflicts:
#	package-lock.json
#	src/App.vue
#	src/components/HelpSection.vue
#	src/components/StepHeader.vue
#	src/components/Stepper.vue
#	src/locales/en.json
#	tests/unit/specs/components/HelpSection.spec.js
@obulat
Copy link
Contributor Author

obulat commented Dec 15, 2020

All of the changes introduced in this PR have actually already been merged as part of #252.. Here, I've added the changes to HTML generation to ensure that the generated HTML has the correct text. Previously, after we've changed the generated text for CC0 ('marked' instead of 'licensed'), the HTML generation has not been updated, and it was generating a phrase like 'This work CC BY' instead of 'This work has been licensed under CC BY'

@obulat obulat changed the title Fix error when pasting the copied license/mark richtext Fix HTML generation error Dec 15, 2020
@obulat
Copy link
Contributor Author

obulat commented Dec 18, 2020

Closing this as the changes have already been merged.

@obulat obulat closed this Dec 18, 2020
@obulat obulat deleted the icons branch January 19, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bugs when copying information from the attribution box

1 participant