Skip to content

Shifting e2e testing from nightwatch to cypress #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
Cronus1007 opened this issue Jan 9, 2021 · 2 comments · Fixed by #299
Closed
1 task done

Shifting e2e testing from nightwatch to cypress #294

Cronus1007 opened this issue Jan 9, 2021 · 2 comments · Fixed by #299
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@Cronus1007
Copy link
Member

Problem and Reasons

A suggestion from my side is that nightwatch being a powerful tool for e2e testing but when it comes to cypress it is far better than nightwatch in my opinion
The enlisted reasons are :-
1.Since chooser is a purely vue/js based repo so cypress is highly recommended for js repos.
2. Also provides Parallel execuion while passing a --parallel flag
3. Cross Browser Testing
4. Much Stable
5. Enhanced Debuggability

Alternatives

There are many other e2e testing tools like TestCafe and various others

Implementation

  • I would be interested in implementing this feature.
@Cronus1007 Cronus1007 added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Jan 9, 2021
@obulat
Copy link
Contributor

obulat commented Jan 10, 2021 •
edited
Loading

I support moving the e2e testing from Nightwatch to Cypress, for several reasons:

  1. Stability of the tests thanks to automatic waiting. The current e2e tests in the Chooser often fail because an element is not interactable. This was made worse when we added automatic scrolling after a step is complete.
  2. Debuggability of the tests.
  3. Parallel execution feature.
  4. Cypress is used in other CC repos.

Could you raise a PR with the initial Cypress setup, @Cronus1007 ?

@Cronus1007
Copy link
Member Author

@obulat Sure I will raise a PR.

@Cronus1007 Cronus1007 mentioned this issue Jan 11, 2021
Merged
7 tasks
obulat added a commit that referenced this issue Jan 11, 2021
@Cronus1007 @obulat
Initial cypress setup for the required shifting of e2e testing from n…
8bfcc1b 
…ightwatch to cypress (#299)

* initial cypress setup #294

* changes as requested by obulat

* Sync package-lock.json

Co-authored-by: Olga Bulat <obulat@gmail.com>
This was referenced Jan 11, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial cypress setup for the required shifting of e2e testing from nightwatch to cypress
2 participants
@obulat @Cronus1007