Skip to content

Default build output without header and footer #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
brylie opened this issue Jan 25, 2022 · 4 comments
Closed
2 tasks

Default build output without header and footer #384

brylie opened this issue Jan 25, 2022 · 4 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work

Comments

@brylie
Copy link
Contributor

brylie commented Jan 25, 2022

The current default build output contains a header and footer. Rather the default should only include the Chooser component, without surrounding page elements, since the Chooser is intended to be embedded into other pages/projects.

Task

  • change the default build output so it doesn't contain a header, breadcrumbs, or footer
  • the default output should only include Chooser sub-components
@brylie brylie added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Jan 25, 2022
@brylie
Copy link
Contributor Author

brylie commented Jan 26, 2022

This issue has been partially fixed by modifying the build-component command in package.json to default to embedded mode:

"build-component": "rm -rf dist && VUE_APP_CC_OUTPUT=embedded vue-cli-service build --target wc --name license-chooser src/main.js",

However, ideally, we wouldn't need the embedded flag.

@brylie brylie added good first issue New-contributor friendly help wanted Open to participation from the community and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 26, 2022
@cc-open-source-bot cc-open-source-bot added 🏷 status: label work required Needs proper labelling before it can be worked on and removed 🏷 status: label work required Needs proper labelling before it can be worked on labels Jan 27, 2022
@brylie
Copy link
Contributor Author

brylie commented Jan 31, 2022

@shailee-m, can we close this issue?

@shailee-m
Copy link
Contributor

@brylie Yes

@shailee-m
Copy link
Contributor

@brylie I do not have the access to close this issue

@brylie brylie closed this as completed Jan 31, 2022
@brylie brylie self-assigned this Feb 14, 2022
@TimidRobot TimidRobot added 🚧 status: blocked Blocked & therefore, not ready for work and removed help wanted Open to participation from the community good first issue New-contributor friendly 🏷 status: label work required Needs proper labelling before it can be worked on labels Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚧 status: blocked Blocked & therefore, not ready for work
Projects
None yet
Development

No branches or pull requests

4 participants