-
-
Notifications
You must be signed in to change notification settings - Fork 180
Building chooser as a web components #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
88cbca2 to
5fbac06
Compare
|
@brylie I have also added a fix for the unit test cases and integration test cases that were failing. For the unit test cases it required a babel plugin to use some webpack functionality. All integration test cases were failing as the queries were done outside the iframe. I have created a wrapper for selecting iframe. Should I add in the docs too? For this, you will have to change the test pipeline commands. Use |
|
Yes, please update the docs. With the web component approach, the Could you also include a demo/example code showing how to use the Chooser web component in a standard HTML page? |
|
@brylie Used this in custom html to integrate it |
Go ahead and add the example code to the project README, assuming we will use unpkg as CDN instead of localhost. |
done |
|
Due to Could you please include the contents of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please include the contents of the dist/ folder in this pull request so I can test the files locally?
|
Once we publish the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hei @shailee-m. The Vocabulary Components package now has a 0.1.0 release:
https://www.npmjs.com/package/@creativecommons/vocabulary-components
Let's use vocabulary-components as a dependency here, instead of vue-vocabulary.
03cf6d2 to
860a2c3
Compare
@brylie removed dist folder and added vocabulary-components as dependency |
30d219d to
abaac34
Compare
|
@brylie added assets, and fonts dependency. Also, created this PR to move assets to cc-assets folder |
Let's keep the "degrees of openness" image in this project for now or link directly to a version hosted on the Wikimedia Commons. FontAwesome icons, like the info circle should be imported directly from FontAwesome. |
…nces or missing dependencies
659358c to
d70dc13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least one of the FontAwesome icons is displayed really large, seen below. If this isn't trivial to fix in the current pull request, we can open a follow-up bug fix.
Steps to reproduce:
- in license step 1, choose "Yes. I know the license I need."
- in step 2, choose a license
- view the "Recommended License" section, below the license icons
done |

Fixes
Fixes #366 by @brylie
Fixes #374
Description
Wraps in vue component wrapper and builds into a web component. Added new build command for the same
Checklist
Update index.md).mainormaster).visible errors.