Skip to content

[WIP] Add chooser functionality #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2019
Merged

Conversation

akmadian
Copy link
Member

@akmadian akmadian commented Jun 19, 2019

Description
Adds the license chooser functionality to page.

Checklist:

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@akmadian akmadian requested a review from brenoferreira June 19, 2019 22:07
@akmadian
Copy link
Member Author

akmadian commented Jun 20, 2019

I think this version of the chooser functionality is pretty much done, let's :shipit: :) If you could give it one last review @brenoferreira that would be great

@akmadian akmadian requested a review from brenoferreira June 20, 2019 20:50
@akmadian
Copy link
Member Author

I'm gonna go ahead and merge this because it's holding up work on adding more modal contents and the icons selection system.

@akmadian akmadian merged commit 8184284 into master Jun 21, 2019
@akmadian akmadian deleted the implement-chooser-functionality branch June 21, 2019 22:43
zackkrida pushed a commit that referenced this pull request Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants