Skip to content

Added unit and e2e tests for the LicenseCode.vue component #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 15, 2020

Conversation

hemanth-hk
Copy link
Contributor

@hemanth-hk hemanth-hk commented Mar 6, 2020

Fixes #117

Description

This PR consists of the unit and e2e tests for the LicenseCode.vue component
unit tests also have the snapshot tests.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and, I
    have the right to submit it under the open-source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open-source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@hemanth-hk hemanth-hk requested review from a team March 6, 2020 22:02
@obulat obulat self-requested a review March 7, 2020 07:49
@obulat obulat self-assigned this Mar 7, 2020
@obulat obulat mentioned this pull request Mar 7, 2020
6 tasks
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is pretty good! You've covered a large majority of the cases I wanted to see, but I think we could add a few more (see my comments). Generally, with tests, you want to test every corner of the thing being tested. I noticed that you tested the richtext "corner", but didn't test the HTML or the print attribution "corners". Testing every possible state permutation isn't necessary, but you generally want to be sure of the basics.

Good work! Just address the comments and I think we should be good to go :)

@akmadian
Copy link
Member

I also just noticed that there's an uncovered line, please add a test for line 80 to be sure that the empty string there is returned when appropriate :)

@hemanth-hk
Copy link
Contributor Author

Thank you for reviewing the code even though you were busy...I made all the changes, hence review it whenever you are free :)

Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for working on this :)

@akmadian akmadian merged commit f094cf0 into creativecommons:master Mar 15, 2020
.assert.elementPresent('.pagination-next')
.click('.pagination-next')
.assert.elementPresent('.select > select')
.click('.select > select')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line causes an error running tests:

Error while running .clickElement() protocol action: element click intercepted: Element ... is not clickable at point (871, 102). Other element would receive the click
: ...

If you click on span.select, you will get the result you were expecting, and the tests run fine.

The same happens in LicenseDetailsCard

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test passed when I was sending a pull request, thank you for pointing this out I'll surely edit this :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test passed when I was sending a pull request, thank you for pointing this out I'll surely edit this :)

I think it passed for me before, too. Anyways, I opened an issue, and I think it's best if I assign it to you. Thank you for quick reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit and e2e tests for the LicenseCode component
3 participants