Skip to content

Move modal rendering using VueSimplePortal #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

obulat
Copy link
Contributor

@obulat obulat commented May 20, 2020

Fixes

Fixes #165 by @obulat and #159 by @SaurabhAgarwala

Description

Currently, modals are rendered as child elements of help component, which makes them use styling of the parent elements. Because of this, various positioning and z-index problems arise, including the issues mentioned in #165:

  • select ::after element is not clickable because it's underneath another element. So, we cannot select a language for the site.

  • footer text is visible through the modal.

VueSimplePortal enables us to render the modal html to an element at the bottom of the page, outside other parent elements, and solves these issues.

Screenshots

CCZIndexIssueSolvedFooterModal

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested review from a team and brenoferreira and removed request for a team May 20, 2020 12:21
@obulat
Copy link
Contributor Author

obulat commented May 24, 2020

This PR was replaced with #171 with a cleaner history.

@obulat obulat closed this May 24, 2020
@obulat obulat deleted the modal-portal branch May 24, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language selector is not clickable and footer text is visible through modal
1 participant