Skip to content

Fix Modal positioning #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2020
Merged

Fix Modal positioning #171

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41d9910
Fix Modal positioning
obulat May 24, 2020
3ec7f55
Remove unused ModalForm string and fix modal footer positioning
obulat May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unused ModalForm string and fix modal footer positioning
  • Loading branch information
@obulat
obulat committed May 25, 2020
commit 3ec7f55f9cf73300a4a4e3497663c10ad3bf7ae0
45 changes: 13 additions & 32 deletions src/components/HelpSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@
class="help-text"
v-html="this.$t('help.what-are-cc-licenses.text')"
/>
<footer class="modal-card-foot">
<p v-html="this.$t('help.what-are-cc-licenses.footer')" />
</footer>
</section>
<footer class="modal-card-foot">
<p v-html="this.$t('help.what-are-cc-licenses.footer')" />
</footer>
</b-modal>
</Portal>
<Portal selector="#portal-target">
Expand All @@ -45,11 +45,11 @@
</header>
<section class="modal-card-body">
<article v-html="this.$t('help.how-licenses-work.text')" />
<footer
class="modal-card-foot"
v-html="this.$t('help.how-licenses-work.footer')"
/>
</section>
<footer
class="modal-card-foot"
v-html="this.$t('help.how-licenses-work.footer')"
/>
</b-modal>
</Portal>
<Portal selector="#portal-target">
Expand Down Expand Up @@ -136,10 +136,10 @@
</header>
<section class="modal-card-body">
<article v-html="this.$t('help.considerations-before-licensing.text')" />
<footer class="modal-card-foot">
<p v-html="this.$t('help.considerations-before-licensing.footer')" />
</footer>
</section>
<footer class="modal-card-foot">
<p v-html="this.$t('help.considerations-before-licensing.footer')" />
</footer>
</b-modal>
<b-modal :active.sync="modals[5].status">
<header class="modal-card-head">
Expand Down Expand Up @@ -168,11 +168,10 @@
<img src="../assets/license-openness-scale.png">
</div>
</div>

<footer class="modal-card-foot">
<p v-html="this.$t('help.six-cc-licenses.footer')" />
</footer>
</section>
<footer class="modal-card-foot">
<p v-html="this.$t('help.six-cc-licenses.footer')" />
</footer>
</b-modal>
</Portal>
<Portal selector="#portal-target">
Expand Down Expand Up @@ -234,24 +233,6 @@
import LicenseIcons from './LicenseIcons'
import { Portal } from '@linusborg/vue-simple-portal'

// eslint-disable-next-line
const ModalForm = {
template: `
<form action="">
<div class="modal-card" style="width: auto">
<header class="modal-card-head">
<p class="modal-card-title">Login</p>
</header>
<section class="modal-card-body">

</section>
<footer class="modal-card-foot">
<button class="button" type="button" @click="$parent.close()">Close</button>
</footer>
</div>
</form>
`
}
export default {
components: {
LicenseIcons,
Expand Down