Skip to content

Update AttributionDetailsStep form for clarity #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Update AttributionDetailsStep form for clarity #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update AttributionDetails step for clarity
  • Loading branch information
@obulat
obulat committed Oct 30, 2020
commit 0ce17dd2dfc9ea48cb8b5cd7fa4cc1738cf75986
12 changes: 6 additions & 6 deletions src/components/AttributionDetailsStep.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@
:placeholder="this.$t('stepper.AD.form.creator-name.placeholder')"
/>
</b-field>
<b-field :label="this.$t('stepper.AD.form.creator-profile.label')">
<b-input
v-model="creatorProfileUrl"
:placeholder="this.$t('stepper.AD.form.creator-profile.placeholder')"
/>
</b-field>
<b-field :label="this.$t('stepper.AD.form.work-title.label')">
<b-input
v-model="workTitle"
Expand All @@ -32,6 +26,12 @@
:placeholder="this.$t('stepper.AD.form.work-url.placeholder')"
/>
</b-field>
<b-field :label="this.$t('stepper.AD.form.creator-profile.label')">
<b-input
v-model="creatorProfileUrl"
:placeholder="this.$t('stepper.AD.form.creator-profile.placeholder')"
/>
</b-field>
</form>
</div>
</div>
Expand Down
10 changes: 5 additions & 5 deletions src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,20 +68,20 @@
"instructions": "Filling out this form is optional, but helps others attribute your work to you, and fills in machine-readable code.",
"form": {
"creator-name": {
"label": "Work Author",
"label": "Creator of Work",
"placeholder": "Jane Doe"
},
"creator-profile": {
"label": "URL of creator profile",
"placeholder": "www.author.com"
"label": "Link to Creator Profile",
"placeholder": "https://janedoe.com"
},
"work-title": {
"label": "Title of Work",
"placeholder": "This work"
},
"work-url": {
"label": "Work URL",
"placeholder": "www.author.com/work.jpg"
"label": "Link to Work",
"placeholder": "https://janedoe.com/best-photo-ever.jpg"
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions tests/unit/specs/components/__snapshots__/AttributionDetailsStep.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports[`AttributionDetailsStep Component Rendering Component mounted if status
<label
class="label"
>
stepper.AD.form.creator-profile.label
stepper.AD.form.work-title.label
</label>

<div
Expand All @@ -62,7 +62,7 @@ exports[`AttributionDetailsStep Component Rendering Component mounted if status
<input
autocomplete="on"
class="input"
placeholder="stepper.AD.form.creator-profile.placeholder"
placeholder="stepper.AD.form.work-title.placeholder"
type="text"
/>

Expand All @@ -82,7 +82,7 @@ exports[`AttributionDetailsStep Component Rendering Component mounted if status
<label
class="label"
>
stepper.AD.form.work-title.label
stepper.AD.form.work-url.label
</label>

<div
Expand All @@ -91,7 +91,7 @@ exports[`AttributionDetailsStep Component Rendering Component mounted if status
<input
autocomplete="on"
class="input"
placeholder="stepper.AD.form.work-title.placeholder"
placeholder="stepper.AD.form.work-url.placeholder"
type="text"
/>

Expand All @@ -111,7 +111,7 @@ exports[`AttributionDetailsStep Component Rendering Component mounted if status
<label
class="label"
>
stepper.AD.form.work-url.label
stepper.AD.form.creator-profile.label
</label>

<div
Expand All @@ -120,7 +120,7 @@ exports[`AttributionDetailsStep Component Rendering Component mounted if status
<input
autocomplete="on"
class="input"
placeholder="stepper.AD.form.work-url.placeholder"
placeholder="stepper.AD.form.creator-profile.placeholder"
type="text"
/>

Expand Down
3 changes: 2 additions & 1 deletion tests/unit/specs/components/__snapshots__/Stepper.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ exports[`Stepper.vue renders correctly has expected UI initially 1`] = `
</div>
<firststep-stub stepid="0" status="current"></firststep-stub>
<nav class="step-navigation">
<!----> <a role="button" class="pagination-next disabled">NEXT STEP</a></nav>
<!----> <a role="button" class="pagination-next disabled">NEXT STEP</a>
</nav>
</div>
<div class="step-container BY inactive enabled">
<div class="step-header">
Expand Down