Skip to content

Refactor navigation #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 2, 2020
Merged

Refactor navigation #232

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
511bfcf
Use Vocabulary VButton for 'Previous' and 'Next' buttons
obulat Nov 25, 2020
708b6b0
Update tests
obulat Nov 25, 2020
e0dbdad
Extract step navigation to a separate component
obulat Nov 25, 2020
553476c
Update tests
obulat Nov 25, 2020
753bb4f
Refactor: combine Step and FirstStep into ChooserStep
obulat Nov 25, 2020
b6b0344
Remove console.log
obulat Nov 25, 2020
22f456d
Merge branch 'master' into refactor_navigation
obulat Dec 2, 2020
dd28e7d
Remove unused FirstStep and Step components
obulat Dec 2, 2020
4e05d9c
Remove failing tests
obulat Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove console.log
  • Loading branch information
@obulat
obulat committed Dec 2, 2020
commit b6b03440341d9735444e4a8e7090b350d043f90d
1 change: 0 additions & 1 deletion src/components/ChooserStep.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ export default {
return this.reversed ? !this.selected : this.selected
},
cardText() {
console.log('Will return card text: ', this.stepName, this.$props.selected)
if (this.stepName === 'FS') {
return this.$props.selected ? 'stepper.FS.selected' : 'stepper.FS.not-selected'
}
Expand Down