Fix attribution information for CC0 #237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #207 by @panchovm
Description
This issue fixes the attribution for CC0 correcting it from "is licensed under" to "is marked with".
Technical details
Patch #221 was accepted for the same issue, but what it does is actually incorrect, as is the explaination in #207 (comment).
That patch does not actually change the attribution generated for any license nor for CC0. What it does is changing the attribution in the footer (which is of a CC BY 4.0 work) from "licensed under a" to "marked with a", which makes little sense since CC BY is a license.
I fixed it back to "licensed", however writing "licensed under the" instead of "licensed under a". The reasoning is that, while the first is actually common, there is only one CC BY International 4.0 license, so I think "the" makes more sense. Either way "marked as" should never have been in the footer, since that was for the generated attribution for CC0 works.
Tests
Testing this PR is quite easy.
I generated a few examples of attributions, both for CC0 and for licenses, and it seems to work, both for the preview and the generated HTML.
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin