-
-
Notifications
You must be signed in to change notification settings - Fork 180
Add deploy script #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deploy script #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, although the copy process could just as easily be accomplished with rm and cp and prevent us from adding a new package just for this purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this:
package.json
Outdated
| "scripts": { | ||
| "serve": "vue-cli-service serve", | ||
| "build": "vue-cli-service build", | ||
| "build": "vue-cli-service build && node deploy.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "build": "vue-cli-service build && node deploy.js", | |
| "build": "vue-cli-service build && rm -r ./docs && cp -r ./dist ./docs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also
echo "<domain>" > CNAME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much cleaner! It doesn't work on Windows, but I guess we don't have to build on Windows anyways. I will add the change once I test it on Ubuntu (WSL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there still changes to package-lock.json?
I have deleted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, that makes sense. Approved 👍
Fixes
Fixes #[issue number] by @[issue author]
Description
This PR adds a script to copy built files from the
distfolder to thedocsfolder, and adds the CNAME file to it so that thedocsfolder is ready for deployment on the github pages.Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin