Skip to content

Conversation

@neeraj-2
Copy link
Contributor

Fixes

Fixes #256 by @panchovm

Description

It updates the hover styling of the default links.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.MD).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat
Copy link
Contributor

obulat commented Dec 17, 2020

@neeraj-2 , you haven't updated your fork, and there have been some big changes to the repo code. You can merge creativecommons master into your fork to update.
I removed the '!important' declarations from styling because they make it very difficult to override and therefore, are not best practice. Also, we don't actually need to change the color on hover, it actually stays the same. What we do need to do here is to add text-decoration: underline on hover.

@neeraj-2
Copy link
Contributor Author

@neeraj-2 , you haven't updated your fork, and there have been some big changes to the repo code. You can merge creativecommons master into your fork to update.
I removed the '!important' declarations from styling because they make it very difficult to override and therefore, are not best practice. Also, we don't actually need to change the color on hover, it actually stays the same. What we do need to do here is to add text-decoration: underline on hover.

Sure @obulat, I'll update the fork and will create a new PR. Thanks for the information.

@neeraj-2 neeraj-2 closed this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hover style of default links

2 participants