Skip to content

Conversation

@rohan-goel
Copy link
Contributor

Fixes

Fixes #262 by @panchovm

Description

Decreased padding-bottom in step header and padding-top in stepper from 8px to 4px
Increased font-size from 16px to 18px

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@rohan-goel rohan-goel requested a review from a team as a code owner December 17, 2020 13:00
@rohan-goel rohan-goel requested review from akmadian and removed request for a team December 17, 2020 13:00
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, you will also need to merge master into your branch, as there have been other changes in the repo, @rohan-goel .

@rohan-goel rohan-goel requested a review from obulat December 17, 2020 16:51
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding changes so quickly, @rohan-goel !
The ticket has to do with the mobile styles, not the desktop, so, could you please revert the changes that you've made to Stepper and StepHeader for normal styles, and add them for max-width: 768px?
We also need to add the following styles here:

.step-header__caption {

.step-header__caption needs the following styles:

font-size: 1rem;
font-weight: 400;
line-height: 1.5rem;

}
.body-normal {
font-size: 0.8125rem;
font-size: 1.125rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style here should be:

font-size: 1rem;
font-weight: 400;
line-height: 1.5rem;

@rohan-goel rohan-goel mentioned this pull request Dec 18, 2020
7 tasks
@rohan-goel rohan-goel requested a review from obulat December 18, 2020 07:57
@obulat obulat closed this in #277 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text style and alignment in radio component

2 participants