-
-
Notifications
You must be signed in to change notification settings - Fork 163
.xmp
support in license attribution
#272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 6f09c17
@fkohrt, could you please look at this PR? I think you know a lot about xmp metadata. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at xmp.js and besides the two suggestions it looks good to me. I'd also suggest running a diff
on the output of this vs. the cc.engine.
# Conflicts: # src/App.vue # tests/e2e/page-objects/chooser.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the src/utils/xmp.js
helper. Nicely written code. Great!
Fixes
Fixes #197 by @fkohrt
Description
This PR adds the machine-readable code in .xmp format for embedding license information into files.
Technical details
Tests
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin