-
-
Notifications
You must be signed in to change notification settings - Fork 180
Add Vocabulary Input implementation instead of buefy input #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| value: { | ||
| type: String, | ||
| default: '' | ||
| }, | ||
| type: { | ||
| type: String, | ||
| default: 'text' | ||
| }, | ||
| label: { | ||
| type: String, | ||
| default: '' | ||
| }, | ||
| description: { | ||
| type: String, | ||
| default: '' | ||
| }, | ||
| placeholder: { | ||
| type: String, | ||
| default: '' | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use inheritAttrs: false and then place the $attrs on the input. See docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for a late reply, @dhruvkb ! I was writing this component as a more general Input component for Vocabulary that can be a text input or a text area. The solution you propose is really clean, but for a simpler component.
Some of these props, such as description, label, value are necessary for the component itself, and some could be bound to the input or the textarea, so I thought leaving them as props would be better.
# Conflicts: # src/App.vue # src/components/AttributionDetailsStep.vue
# Conflicts: # docs/index.html # package-lock.json
|
@obulat Some small merge conflicts; but otherwise this looks good! |
# Conflicts: # tests/unit/specs/components/App.spec.js
|
With this PR merged, the size of |
Fixes
Fixes #224 by @obulat
Fixes #259 by @panchovm
Description
This PR replaces a buefy input component with VInput component in the Attribution Details step. When this component is reviewed and merged into Vocabulary, Chooser will convert to that, so this is a temporary solution.
Screenshots
Mobile:

Tablet and up:

Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin