Skip to content

Conversation

@obulat
Copy link
Contributor

@obulat obulat commented Dec 17, 2020

Fixes

Fixes #224 by @obulat
Fixes #259 by @panchovm

Description

This PR replaces a buefy input component with VInput component in the Attribution Details step. When this component is reviewed and merged into Vocabulary, Chooser will convert to that, so this is a temporary solution.

Screenshots

Mobile:
image

Tablet and up:
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from dhruvkb December 17, 2020 18:53
@obulat obulat requested a review from a team as a code owner December 17, 2020 18:53
@obulat obulat requested review from akmadian and removed request for a team December 17, 2020 18:53
Comment on lines +52 to +71
value: {
type: String,
default: ''
},
type: {
type: String,
default: 'text'
},
label: {
type: String,
default: ''
},
description: {
type: String,
default: ''
},
placeholder: {
type: String,
default: ''
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use inheritAttrs: false and then place the $attrs on the input. See docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for a late reply, @dhruvkb ! I was writing this component as a more general Input component for Vocabulary that can be a text input or a text area. The solution you propose is really clean, but for a simpler component.

Some of these props, such as description, label, value are necessary for the component itself, and some could be bound to the input or the textarea, so I thought leaving them as props would be better.

@obulat obulat requested a review from hugosolar January 8, 2021 20:19
# Conflicts:
#	docs/index.html
#	package-lock.json
@zackkrida
Copy link
Member

@obulat Some small merge conflicts; but otherwise this looks good!

@obulat
Copy link
Contributor Author

obulat commented Jan 21, 2021

With this PR merged, the size of chunk-vendors.js decreased from 649.41 KiB to 388.52 KiB (or from 187.05 KiB to 126.59 KiB gzipped), the sent file is now more than 30% smaller!

@obulat obulat dismissed dhruvkb’s stale review January 21, 2021 18:04

There was another approving review

@obulat obulat merged commit e5656e5 into creativecommons:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text style in the name of input component Use Vocabulary VInput component

4 participants