Skip to content

Conversation

@obulat
Copy link
Contributor

@obulat obulat commented Dec 17, 2020

Fixes

Fixes #227 by @obulat

Description

This PR replaces a buefy select component with a VSelect component in the Dropdown step. When this component is reviewed and merged into Vocabulary, Chooser will convert to that, so this is a temporary solution.

Screenshots

There is no need for a screenshot because the appearance of select is exactly the same.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner December 17, 2020 19:23
@obulat obulat requested review from kgodey and removed request for a team December 17, 2020 19:23
# Conflicts:
#	src/App.vue
#	src/components/DropdownStep.vue
@obulat obulat merged commit 1174e48 into creativecommons:master Jan 7, 2021
@obulat obulat deleted the vselect branch January 7, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Vocabulary select component

2 participants