Move modals to a separate component and replace markdown in locales with HTML #311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #279 by @obulat
Description
Currently, the Modals for the Help section in the Chooser are converted from markdown in the
locales.jsonfiles to HTML usingmarkdown-itpackage at runtime. This PR replaces markdown with HTML to improve bundle size. Modals are also moved to a separate component to improve code organization.Technical details
This PR extracts help modals from the
HelpSectioncomponent into a separateChooserModalcomponent.Previously, we have introduced
vue-simple-portalpackage to render the modals in a separate div at the end of the body to fix a rendering problem: without the portal, you could see the underlying text through the modal. With the introduction ofAppModalcomponent from Vue Vocabulary, this problem was solved, so this PR removesvue-simple-portalpackage.This PR also removes markdown from the modals, replacing them with HTML instead.
These changes make the un-compressed
chunk-vendors100 KiB smaller:Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
Developer Certificate of Origin