Skip to content

Accessibility: Setting headings' visual styles in an accessible way #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Accessibility: Setting headings' visual styles in an accessible way #320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48b7b1a
sequential_descending_order_for_heading_added
neeraj-2 Feb 17, 2021
e83a725
letter-spacing-styles-added-in-stepheader
neeraj-2 Feb 18, 2021
30c0fb9
Remove failing stepper unit test.
zackkrida Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
</ul>
</nav>

<h2>
<h1 class="title is-2">
{{ $t('chooser.heading') }}
</h2>
</h1>
<p class="stepper-instructions body-bigger">
{{ $t('chooser.instructions') }}
</p>
Expand Down
4 changes: 3 additions & 1 deletion src/components/FooterSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@
</div>
<div class="column">
<section class="donate-section">
<h5>{{ $t('footer.donation.header') }} </h5>
<h2 class="title is-5">
{{ $t('footer.donation.header') }}
</h2>
<p>{{ $t('footer.donation.call') }}</p>
<a
class="button small donate"
Expand Down
4 changes: 2 additions & 2 deletions src/components/HelpSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<template>
<div class="help-section">
<h3>
<h2 class="title is-3">
{{ $t('help.heading') }}
</h3>
</h2>
<ul class="help-links">
<li
v-for="(modal, idx) in modals"
Expand Down
4 changes: 2 additions & 2 deletions src/components/StepHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
@click="activate"
@keyup.13="activate"
>
<h5 class="step-header__title b-header">
<h2 class="step-header__title b-header title is-5">
{{ $t(stepHeaderText) }}
</h5>
</h2>
<div
v-if="step.status === 'completed'"
class="step-header__caption"
Expand Down