Skip to content

Conversation

@Cronus1007
Copy link
Member

@Cronus1007 Cronus1007 commented Feb 22, 2021

Fixes

Fixes #325 by @zackkrida

Description

  • Added the yearOfCreation input feild in AD for all the licenses except CC0

Technical details

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Cronus1007 Cronus1007 requested a review from a team as a code owner February 22, 2021 06:47
@Cronus1007 Cronus1007 requested review from akmadian and removed request for a team February 22, 2021 06:47
@Cronus1007 Cronus1007 marked this pull request as draft February 22, 2021 06:47
@Cronus1007 Cronus1007 changed the title Isse 325 added new 'year-of-creation' attribution details Feb 22, 2021
@Cronus1007
Copy link
Member Author

@obulat I am able to update the Attribution Details to get the year of Creation and storing the value but unable to update the front End Template.

@Cronus1007 Cronus1007 marked this pull request as ready for review February 23, 2021 12:13
obulat
obulat previously requested changes Feb 25, 2021
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Year of creation should only be added to licenses, not the CC0.
So, can you please remove the Year field in the AttributionDetails for CC0, and the license code.

@Cronus1007
Copy link
Member Author

Cronus1007 commented Feb 25, 2021

@obulat I am planning to do it via adding the shortName attribute to the attributionDetails and then toogle will be as per the shortname. Whats your opinion upon it?

@obulat
Copy link
Contributor

obulat commented Feb 25, 2021

@obulat I am planning to do it via adding the shortName attribute to the attributionDetails and then toogle will be as per the shortname. Whats your opinion upon it?

Yes, using the shortName getter is a great idea.
I guess by 'toggle' you mean the v-if condition where you show the field if the shortName isn't equal to CC0.

@Cronus1007
Copy link
Member Author

I guess by 'toggle' you mean the v-if condition where you show the field if the shortName isn't equal to CC0.

Yes.

@Cronus1007 Cronus1007 requested a review from obulat February 25, 2021 10:04
@Cronus1007
Copy link
Member Author

Cronus1007 commented Feb 25, 2021

@obulatI have resolved the test conflicts as well. Now the PR is ready for being reviewed.
Screenshot from 2021-02-25 15-53-03

@zackkrida zackkrida dismissed obulat’s stale review February 25, 2021 23:41

Changes were made!

@zackkrida zackkrida merged commit 0a1eedc into creativecommons:master Feb 25, 2021
@Cronus1007 Cronus1007 deleted the isse-325 branch February 26, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new "year of creation" attribution detail

3 participants