Skip to content

Conversation

@obulat
Copy link
Contributor

@obulat obulat commented Feb 26, 2021

Description

This PR removes the old Selenium e2e tests that were too brittle/ redundant. Instead, we created the integration tests that test the workflow of several components together, using Cypress.

Technical details

The Cypress tests are moved to the tests directory instead of a separate 'cypress' directory.
The integration tests are added to the GitHub actions' 'Lint and Test' workflow CI.
Some documentation was updated accordingly.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner February 26, 2021 11:47
@obulat obulat requested review from kgodey and removed request for a team February 26, 2021 11:47
@obulat obulat force-pushed the final_cypress_switch branch from 6535970 to 8b2dbd2 Compare February 26, 2021 12:25
@obulat obulat requested a review from zackkrida February 26, 2021 13:59
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement for several reasons:

  • No longer requires Java as a dependency
  • Removes ~20k lines of code for the same test coverage
  • The cypress helper functions streamline things nicely

Thank you!

@zackkrida zackkrida merged commit 69d3915 into creativecommons:master Mar 4, 2021
@Cronus1007
Copy link
Member

Cronus1007 commented Mar 4, 2021

@obulat Shall I also extend the Cypress tests to the new functionality that has been added recently to the repository.
Plus there is a need to extend the Cypress tests for checking the functionality of helper section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants