Skip to content

Conversation

@yaya-usman
Copy link
Contributor

Fixes

Fixes #[#372] issue reported by @brylie

Description

  • removed Hotjar/analytics code from Vue components
  • removed Hotjar packages from package.json including vue-analytics

Checklist

  • [x ] My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@yaya-usman yaya-usman requested a review from a team as a code owner January 31, 2022 09:11
Copy link
Contributor

@brylie brylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to delete package-lock.json

@yaya-usman yaya-usman closed this Jan 31, 2022
@yaya-usman yaya-usman reopened this Jan 31, 2022
@yaya-usman
Copy link
Contributor Author

We don't want to delete package-lock.json

Alright, I'll return it

@brylie brylie merged commit f829300 into creativecommons:main Feb 1, 2022
@yaya-usman yaya-usman deleted the Hotjar-related-fix branch February 1, 2022 13:22
@yaya-usman
Copy link
Contributor Author

@brylie Thanks for the merge, by the way, I'll like to note that, noticed there are tons of deprecated dependencies when I did npm install... Probably you guys might consider updating them or some

@brylie
Copy link
Contributor

brylie commented Feb 1, 2022

Thanks for your contribution @yaya-usman. We've taken notice of the deprecation warnings and will work to resolve them in subsequent tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants