Skip to content

WIP: Issue #34 - Unit tests for CopyButton component #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

WIP: Issue #34 - Unit tests for CopyButton component #44

wants to merge 5 commits into from

Conversation

@priscilauchoa
Copy link
Contributor

@priscilauchoa priscilauchoa commented Oct 3, 2019

Fixes #34

Description
WIP

Other information
WIP

Checklist:
WIP

akmadian
akmadian previously requested changes Oct 3, 2019
View reviewed changes
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the spec file into ./test/unit/specs/components/, I am changing the file structure a bit to stay more organized.

@akmadian akmadian dismissed their stale review October 3, 2019 20:47

Fixed :)

@priscilauchoa
Copy link
Contributor Author

priscilauchoa commented Oct 6, 2019 •
edited
Loading

@akmadian FYI. Closing this PR. New one including unit along with e2e tests on PR #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akmadian akmadian akmadian left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Write tests for CopyButton component

2 participants

@priscilauchoa @akmadian