Skip to content

Conversation

@owais0017
Copy link

@owais0017 owais0017 commented Apr 13, 2023

Fixes

Fixes #481 by @Xaid-vfx

Description

https://chooser-beta.creativecommons.org/ here is where you can find the issue. Go to the "Confused? Need help?" part then navigate to "what should i consider" then click on the hyperlink "other considerations" .
the PR basically changes the hypertext with normal text (which was the goal), to remove the issue to moving back to the same page

Tests

you can nagivate to the chooser help section and click on the "what should i consider" and then the hyperlink "other considerations" which takes you back to the same page. so i removed it as mention in the issue

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@owais0017 owais0017 requested review from a team as code owners April 13, 2023 11:51
@owais0017 owais0017 requested review from Shafiya-Heena, annatuma and zackkrida and removed request for a team April 13, 2023 11:51
@possumbilities
Copy link
Contributor

@owais0017 Hi! Thanks for jumping in to contribute. Since this is a PR for an Issue that has yet to moved from awaiting triage to ready for work it shouldn't have been submitted yet.

Please review the following for more info:

Additionally, the nature of the problem has been updated on that Issue, it's not a matter of the link being a mistake, but that it's missing the correct href.

@possumbilities possumbilities self-assigned this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Missing hyperlink in Help Modal

2 participants