-
-
Notifications
You must be signed in to change notification settings - Fork 163
refactor chooser to be more exacting, simplified, and maintainable #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
possumbilities
wants to merge
136
commits into
main
Choose a base branch
from
refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for later comparison tracking on choice pathway selection
cleanup UX and files, enable `help` section, reset `README.md`, fix error with copyright display
correct specificity of styles, narrow scope to only `chooser-page` context, update `README.md`
❌ Deploy Preview for creativecommons-chooser failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The overall goal here is to make the Chooser smaller, clearer, and more easily maintained, while allowing fresh room to implement changes as needed.
npm
)README.md
was updated to match new structure, and functionality.build-component
in package.json #480Metrics
old dependecies :
2748
dependencies (179 vulnerabilities (10 low, 110 moderate, 41 high, 18 critical))32,515
7118
39,633
260,885
refactor dependencies:
1
(Vocabulary)621
369
811
1801
4535
31,894
lines from core JS250,412
lines from JS core + deps32,515
| refactor JS: ~621
| ~98.1% reduction in JavaScript39,633
| refactor core: ~1801
| ~95.45% reduction in core codebase260,885
| refactor (core + deps): ~4535
| ~98.26% reduction in core codebase + depsNote: most of the above metrics were gathered originally via the following commands in the correct directories:
Technical details
<template>
elements<template>
elements<template>
.css
markup is bound to thechooser-page
context and intended to be utilzied as an@layer
@import
within downstream implementation alongside and dependent uponvocabulary
state
when changes happen within certain elements. When updates occur therawStatePaths
are compared to the currentstate
to verify if atool
has been matched, if so the relevanttool
is recommended, if not the tool remains set tounknown
fieldsets
for those unfamiliar with the tools, which need help choosing, are now required prior to a tool recommendation; these include the checkbox fields asserting users are aware of what they are doing prior to utilizing the tool.<details>
and<summary
, rather than more bespoke UI/UX. This comes with a lot of given affordances that don't need to be implicitly set.help
section has been moved to a more semantic location, that is also more visually helpful to a user during "unknown" and "default" states.help
section has been modified to utilize<details>
and<summary>
elements, rather than non semantic, non accessible "links" which open popup modals.fields
have better defaults, marking formats carry defaults over to give clearer indication of their purpose and rendering.marking
sectionvocabulary-theme
, which removes the need to update theglobal header
orglobal footer
components anymore, it will instead inherit from the theme itself as changes are dynamically made within WordPressmirrors.creativecommons.org
address (in the old chooser some formats pull from the chooser's codebase instead)license
has been converted more generally totool
wherever feasible, same with codebase.scss/sass
, move to native non-compiled CSS and utilize more current supported featuresScreenshots
🖼 default state
🖼 license rec state - don't need help
🖼 CC0 rec state - don't need help
🖼 license rec state - need help
🖼 need help section - open
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin