Skip to content

add generic mark toggle to marking formats #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
Merged

add generic mark toggle to marking formats #607

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed9332a
add generic mark checkbox toggles
possumbilities Sep 17, 2025
ac9cffe
setup baseline logic and markup for plain text mark
possumbilities Sep 17, 2025
a6b0fe0
corect naming in markup, add logic for all three mark toggles
possumbilities Sep 19, 2025
53fe379
remove whitespace
possumbilities Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
setup baseline logic and markup for plain text mark
  • Loading branch information
@possumbilities
possumbilities authored Sep 17, 2025
commit ac9cffe8de1ec2566284c01d559817503df59884
4 changes: 4 additions & 0 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,5 +819,9 @@ <h4>Creative Commons Attribution-NonCommercial-NoDerivatives 4.0 International</
<p>{{title}} {{copyright}} by {{creator}} is {{typeAsVerb}} {{toolName}}. To view a copy of this {{type}}, visit {{toolURL}}</p>
</template>

<template id="plain-text-generic-mark" class="mark">
<p>This work is {{typeAsVerb}} {{toolName}}. To view a copy of this {{type}}, visit {{toolURL}}</p>
</template>

</body>
</html>
10 changes: 9 additions & 1 deletion src/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,11 +299,19 @@ function renderMarkingFormats(state) {

if (plainTextFullName == true) {
markProps.toolName = state.props.toolLong;

} else {
markProps.toolName = state.props.toolShort;
}

// determine if generic mark is toggled.
plainTextGenericMark = document.querySelector('#plain-text-generic-mark').checked;

if (plainTextGenericMark == true) {
console.log('plain text generic mark true');
} else {
console.log('plain text generic mark false');
}

// [T]: could carve out separate sections for different mark formats here
// only handles plain text at the moment
for (const [key, value] of Object.entries(markProps)) {
Expand Down