Skip to content

Conversation

@obulat
Copy link
Contributor

@obulat obulat commented Feb 11, 2020

Description

New design is implemented, including new VerticalStepper component for Stepper.
Data shared among various components is moved to vuex store for easier handling.

Other information

Checklist:

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

obulat added 13 commits February 6, 2020 16:04
Signed-off-by: Olga Bulat <obulat@gmail.com>
Convert Help buttons into links; render links using 'modals' object and v-for loop

Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat requested a review from akmadian February 11, 2020 20:39
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to see lots of defunct components being cleaned up!

Some specific things:

  • Now that the vertical stepper is the stepper, I think it would make sense to rename it simply to "Stepper", or "Steps", then renaming the VerticalStep component to simply "Step", or something like this.
  • The store still needs to be moved to ./src/store/index.js from ./store/index.js
  • It seems to make more sense to me to have the Stepper component manage the steps array that is currently in state, additionally, moving the enabledAndVisibleSteps array to the Stepper component. Is there a reason that they are managed by the state? Are these arrays used only by the stepper and its children, or by other components?
  • I'm seeing some choppy behavior when transitioning between selected steps. This may be due to now using VueX bindings for changing selected step instead of having the VerticalStepper component itself manage this. The update to the state would take time to propagate, thus making the transitions choppy.

Overall, looks good! I think it would be good to move more stuff from the store into the VerticalStepper component. A good test would be to ask yourself if the information or method in the store is only used by the stepper, or its children. If it is, it's probably good to move it out of store. In general, I think of the purpose of store as being to track data and global state, not manage behavior - that's for components.

Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Copy link
Member

@akmadian akmadian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! I like how slim the state is now, I think "the division of labor" makes much more sense.

There are a number of text and styling differences between this branch and the Figma, but I assume these will be taken care of in a subsequent PR. Go ahead and merge whenever :)

Signed-off-by: Olga Bulat <obulat@gmail.com>
@akmadian akmadian closed this Feb 21, 2020
@akmadian akmadian deleted the WIP-vuex branch February 21, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants