Skip to content

process to hold application when application is voted 'no' #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

hugosolar
Copy link
Contributor

Fixes

Fixes #396 by @Juliabrungs

Description

This PR adds a process to hold the application when the applicant receives a 'No' vote, so when that happens:

  • The application switches its state to to-be-reviewed in order to wait until MC review and no one else is able to vote
  • it gets a purple mark on the application approval list
  • I reuse the MC review form in order to be used with this process as well
  • When MC review the application
    • If MC approves (Yes): the application changes its state to vouching and the 'No' vote is removed so the application can be voted again
    • If MC reject the application: the application declines and the applicant is notified

Also, there's a couple of tiny fixes

  • Fixed the availability of the vote form based on the amount of votes so far: if the appplicant has more than 5 votes, the form would not show up
  • Style on vouch boxes on the applicant profile (backend)
  • If sentences conflict between the "MC review" form and "voting on application" form

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@hugosolar hugosolar requested review from TimidRobot, zackkrida and a team July 16, 2020 13:32
@hugosolar hugosolar self-assigned this Jul 16, 2020
@hugosolar hugosolar merged commit 9fbdec0 into master Jul 16, 2020
@kgodey kgodey deleted the hold-application branch July 16, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MC member votes no - holds application
3 participants