Skip to content

fix all members query in admin section #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Conversation

hugosolar
Copy link
Contributor

Fixes

Fixes creativecommons/tech-support#647 by @Juliabrungs

Description

This PR fixes the query for all users in the admin section. this happened because the prior query compare the users in the "Final Approval" form and there were some users that don't appear on that form because at the beginning of times the site didn't have that approval workflow.
I replace those users approval dates with the beginning date of the website (2017-10-15)

Technical details

I replace the query to the final approval form with the WP_User_Query WordPress class so we ensure all users are included now.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@hugosolar hugosolar requested review from TimidRobot, zackkrida and a team September 2, 2020 18:24
@hugosolar hugosolar self-assigned this Sep 2, 2020
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

$member_id = $member[CCGN_GF_FINAL_APPROVAL_APPLICANT_ID];
$user = get_user_by('ID', $member_id);

$member_last_date = get_user_meta( $member_id, CCGN_APPLICATION_STATE_DATE, true);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this variable being used anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to remove it. I'll do it immediately
thanks!

@hugosolar hugosolar merged commit eb099dd into master Sep 2, 2020
@hugosolar hugosolar deleted the fix-all-members-query branch September 2, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants