Skip to content

License deed pages have malformed comment appearing above header #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Ythan opened this issue Dec 1, 2020 · 1 comment · Fixed by cc-archive/cc.engine#50
Closed

License deed pages have malformed comment appearing above header #1190

Ythan opened this issue Dec 1, 2020 · 1 comment · Fixed by cc-archive/cc.engine#50
Assignees
@TimidRobot @hugosolar
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟥 priority: critical Must be fixed ASAP 🏁 status: ready for work Ready for work

Comments

@Ythan
Copy link

Ythan commented Dec 1, 2020

All of the license deed pages have a malformed comment which is appearing above the header:

!-- Google Tag Optimize -->

Example URLs:
https://creativecommons.org/licenses/by/4.0/
https://creativecommons.org/licenses/by-sa/4.0/
https://creativecommons.org/licenses/by-nd/4.0/
https://creativecommons.org/licenses/by-nc/4.0/
https://creativecommons.org/licenses/by-nc-sa/4.0/
https://creativecommons.org/licenses/by-nc-nd/4.0/

The legal code pages for the licenses are not affected.

According to web.archive.org it looks like this error was just introduced today (December 1).

Screenshot_2020-12-01 Creative Commons — Attribution 4 0 International — CC BY 4 0
@Ythan Ythan added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Dec 1, 2020
@kgodey kgodey added 🕹 aspect: interface Concerns end-users' experience with the software 🟥 priority: critical Must be fixed ASAP 🏁 status: ready for work Ready for work 🛠 goal: fix Bug fix and removed 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Dec 2, 2020
@kgodey
Copy link
Member

kgodey commented Dec 2, 2020

thanks for reporting this, @Ythan, we're on it.

@hugosolar hugosolar mentioned this issue Dec 2, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimidRobot TimidRobot

@hugosolar hugosolar

Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟥 priority: critical Must be fixed ASAP 🏁 status: ready for work Ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix comment line typo when adding google optimize cc-archive/cc.engine
4 participants
@kgodey @Ythan @TimidRobot @hugosolar