Skip to content

[Feature] Presskit SVGs doesn't work well with non-white backgrounds #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
jacobemcken opened this issue Apr 20, 2025 · 0 comments
Open
1 task done
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧹 status: ticket work required Needs more details before it can be worked on

Comments

@jacobemcken
Copy link

jacobemcken commented Apr 20, 2025

Problem

Presskit SVGs don't work well with non-white backgrounds.

Image
Current behavior on the left and desired behavior on the right.

Description

The SVGs used by the HTML produced by the "License chooser" have a solid white background inside the circle.
The icons are hosted here and are part of the "Presskit" e.g.:
https://mirrors.creativecommons.org/presskit/icons/by.svg

The white background icons from "Presskit" are inconsistent with the icons here (which are transparent):
https://github.com/creativecommons/vocabulary/tree/main/src/svg/cc/icons

I suggest having an extra set of icons in the "Presskit" with transparent centers.
It is probably a good idea to leave the current ones as is for backwards compatibility.
Maybe even use these in the "License chooser" by default moving forward.

Alternatives

Leave everything "as is", but having icons with transparent backgrounds available, we get a web that looks better 😅

Additional context

Maybe also provide SVGs with white "fill color" for dark (themed) websites.

Implementation

  • I would be interested in implementing this feature. (but I would need some pointers as to where I can find this "Presskit")
@jacobemcken jacobemcken added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Apr 20, 2025
@cc-open-source-bot cc-open-source-bot moved this to Triage in TimidRobot Apr 20, 2025
@TimidRobot TimidRobot removed this from TimidRobot Apr 21, 2025
@TimidRobot TimidRobot moved this to Triage in possumbilities Apr 21, 2025
@possumbilities possumbilities moved this from Triage to Backlog in possumbilities Apr 21, 2025
@possumbilities possumbilities added 🧹 status: ticket work required Needs more details before it can be worked on and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧹 status: ticket work required Needs more details before it can be worked on
Projects
Status: Backlog
Development

No branches or pull requests

2 participants