Skip to content

fix donate redirect #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020
Merged

fix donate redirect #1192

merged 1 commit into from
Dec 4, 2020

Conversation

TimidRobot
Copy link
Member

Fixes

Fixes #1191 by @zackkrida

Description

fix donation redirect (do not URL escape destination)

Tests

change is live on server and verified:

http -h https://creativecommons.org/donate
HTTP/1.1 301 Moved Permanently
Age: 0
CF-Cache-Status: DYNAMIC
CF-RAY: 5fc60873d8fe35fe-LAX
Connection: keep-alive
Content-Type: text/html; charset=iso-8859-1
Date: Fri, 04 Dec 2020 13:56:50 GMT
Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
Location: https://classy.org/give/313412/#!/donation/checkout
Server: cloudflare
Set-Cookie: __cfduid=dedb953acd15aaf0288b3a750ae91c5921607090209; expires=Sun, 03-Jan-21 13:56:49 GMT; path=/; domain=.creativecommons.org; HttpOnly; SameSite=Lax
Strict-Transport-Security: max-age=15768000
Transfer-Encoding: chunked
Via: 1.1 varnish (Varnish/5.0)
X-Content-Type-Options: nosniff
X-Frame-Options: deny
X-Varnish: 363353892
X-XSS-Protection: 1; mode=block
cf-request-id: 06cfa39c69000035fe18999000000001

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@TimidRobot TimidRobot requested review from hugosolar, zackkrida, mathemancer and a team December 4, 2020 14:01
@TimidRobot TimidRobot self-assigned this Dec 4, 2020
@TimidRobot TimidRobot merged commit 4956326 into master Dec 4, 2020
@TimidRobot TimidRobot deleted the donate-redirect branch December 4, 2020 14:10
Copy link

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hash # escaping in donation redirect
3 participants