Skip to content

switch to type vcs for vocabulary-theme #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

TimidRobot
Copy link
Member

Description

switch to type vcs for vocabulary-theme

Technical details

docker compose run --rm composer update 2>/dev/null
Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Downloading creativecommons/vocabulary-theme (v0.3.0)
  - Upgrading creativecommons/vocabulary-theme (0.3.0 => v0.3.0): Extracting archive
Generating autoload files
1 package you are using is looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found

JSON normalized with:

f=config/composer/composer.json; jq -SM '.' ${f} > new && mv new ${f}

Tests

docker compose run --rm composer validate 2>/dev/null
./composer.json is valid, but with a few warnings
See https://getcomposer.org/doc/04-schema.md for details on the schema
# General warnings
- require.reyhoun/acf-menu-chooser : exact version constraints (1.1) should be avoided if the package follows semantic versioning
- require.wpackagist-plugin/advanced-custom-fields : exact version constraints (6.1.8) should be avoided if the package follows semantic versioning
- require.wpackagist-plugin/classic-editor : exact version constraints (1.6.3) should be avoided if the package follows semantic versioning
- require.wpackagist-plugin/redirection : exact version constraints (4.9.2) should be avoided if the package follows semantic versioning
- require.wpackagist-plugin/tablepress : exact version constraints (1.14) should be avoided if the package follows semantic versioning
- require.wpackagist-plugin/wordfence : exact version constraints (7.10.3) should be avoided if the package follows semantic versioning
- require.wpackagist-theme/twentytwentythree : exact version constraints (1.2) should be avoided if the package follows semantic versioning

(warnings contradict best practices 🤦🏻 )

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@TimidRobot TimidRobot self-assigned this Aug 11, 2023
@TimidRobot TimidRobot merged commit 5479730 into main Aug 11, 2023
@TimidRobot TimidRobot deleted the composer-theme-vcs branch August 11, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants