Skip to content

Fix: Input the missing "media=all" attribute in the <link> tag #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

babyteega
Copy link
Contributor

@babyteega babyteega commented Oct 15, 2024

Fixes

Description

The tag for the CSS file was missing the media attribute, which is required for proper HTML semantics. In the vocabulary docs, link tag for stylesheets must have the media="all". The media='all' was added to the link tag.

Technical details

Tests

  1. Clone the repo and go to base.html in scholarship folder
  2. Observe that the <link> tag for the CSS file now includes a media attribute:
    https://github.com/babyteega/legaldb/blob/4326db76c9528534588750ea9abd8eadaeae97c9/legal_db/templates/legal_db/base.html#L12
  3. See correction.

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@babyteega babyteega requested review from a team as code owners October 15, 2024 13:07
@babyteega babyteega requested review from TimidRobot, possumbilities and krysal and removed request for a team October 15, 2024 13:07
@babyteega babyteega changed the title Fix: CSS link tag Fix: Missing Media attribute in CSS <link> tag Oct 15, 2024
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please complete the pull request (PR) description.

Also, when creating issues, pull requests or other documentation on GitHub, it almost always a bad idea to screenshot text and code:

@babyteega
Copy link
Contributor Author

Please complete the pull request (PR) description.

Also, when creating issues, pull requests or other documentation on GitHub, it almost always a bad idea to screenshot text and code:

okay, i will work on that now

@babyteega
Copy link
Contributor Author

@TimidRobot i've made the necessary changes.

@TimidRobot
Copy link
Member

@babyteega you still need to complete the Checklist section of the description (check only those that apply)

@babyteega babyteega changed the title Fix: Missing Media attribute in CSS <link> tag Fix: Input the missing "media=all" attribute in the <link> tag Oct 16, 2024
@babyteega
Copy link
Contributor Author

@babyteega you still need to complete the Checklist section of the description (check only those that apply)

Okay, thank you for that, ive done that now.

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TimidRobot TimidRobot merged commit 4983cc9 into creativecommons:main Oct 22, 2024
@TimidRobot TimidRobot self-assigned this Oct 22, 2024
@TimidRobot
Copy link
Member

Deployed to production Tue Oct 22 14:21:33 PDT 2024: #236 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug] CSS Link Tag Does Not Follow Vocabulary Documentation
2 participants