-
Notifications
You must be signed in to change notification settings - Fork 74
Fix: Input the missing "media=all" attribute in the <link> tag #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please complete the pull request (PR) description.
Also, when creating issues, pull requests or other documentation on GitHub, it almost always a bad idea to screenshot text and code:
- GitHub has good support for referencing code: Creating a permanent link to a code snippet - GitHub Docs
- (text is often better represented in code blocks--especially when there is an appropriate syntax highlighting)
okay, i will work on that now |
@TimidRobot i've made the necessary changes. |
@babyteega you still need to complete the Checklist section of the description (check only those that apply) |
Okay, thank you for that, ive done that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Deployed to production |
Fixes
Description
The tag for the CSS file was missing the media attribute, which is required for proper HTML semantics. In the vocabulary docs, link tag for stylesheets must have the media="all". The media='all' was added to the link tag.
Technical details
Tests
<link>
tag for the CSS file now includes a media attribute:https://github.com/babyteega/legaldb/blob/4326db76c9528534588750ea9abd8eadaeae97c9/legal_db/templates/legal_db/base.html#L12
legaldb/legal_db/templates/legal_db/base.html
Line 12 in 83e0303
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin