Skip to content

Conversation

@Ayush-023
Copy link
Contributor

@Ayush-023 Ayush-023 commented Jan 29, 2021

… WHO IS THIS PAGE FOR headings when viewed on devices with a width between 768px to around 1300px.

Fixes

Fixes #76 by @shubhanshu02

Description

This PR fixes the overflows in the divs under headings: What comes after implementation?, About, Who is this page for? when viewed on devices with a width between 768px to around 1300px.

Technical details

Changed the hardcoded sizes in the CSS to fluid sizes.

Screenshots

Screenshot (40)
Screenshot (38)
Screenshot (39)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Ayush-023 Ayush-023 requested a review from a team as a code owner January 29, 2021 11:31
Copy link

@shubhanshu02 shubhanshu02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mentioned the wrong issue; it's #76. The overflow in the divs seems to be gone by these changes, just that the text size in buttons has got a bit smaller to read.

@Ayush-023
Copy link
Contributor Author

Ayush-023 commented Jan 29, 2021

I think you mentioned the wrong issue; it's #76. The overflow in the divs seems to be gone by these changes, just that the text size in buttons has got a bit smaller to read.

Yeah, sorry I mentioned the wrong issue. There is overflow in other buttons on the page too, just the background color and text color is white so it isn't that much visible.
All the other overflow problems seem fixed?
What should I do?

@shubhanshu02
Copy link

shubhanshu02 commented Jan 29, 2021

Yeah, sorry I mentioned the wrong issue. There is overflow in other buttons on the page too, just the background color and text color is white so it isn't that much visible.
All the other overflow problems seem fixed?
What should I do?

@Ayush-023, as far as I can explore with the HTML, I cannot see any overflow now. Let's wait for any member to review this PR.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm content with this solution. Thank you! Anyone involved here who wants to fix the button issue in #72 is welcome to 🎊

@zackkrida zackkrida merged commit 0cdc3f0 into creativecommons:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text Overflow in Divs

3 participants