Skip to content

Resolving the text overflow in Divs ( "What comes after implementation" and "About" section) #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 4, 2021

Conversation

renuka142
Copy link
Contributor

Fixes

fixes #76 by @shubhanshu02

Description

The PR resolves the text overflow occuring in the Div section i.e

  • What comes after implementation
  • About

When viewed on devices with a width between 768px to around 1300px.

Technical Details

changed some hardcoded widths and heights from these cards , for the pt-card and pt-text-card classes:

Tests

  1. Open the "ABOUT" section of the page.
  2. Adjust the width size between 768px to 1300px.
  3. Notice that the text overflow which was occuring previously is rectified.
  4. Follow step 1 and 2 for "WHAT COMES AFTER IMPLEMENTATION" section.

Screenshot

Screenshot (167)

Screenshot (169)

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@renuka142 renuka142 requested a review from a team as a code owner February 13, 2021 06:47
@@ -167,6 +168,8 @@ a.scroll-link:hover {
border-bottom: none;
background: #ffffff;
color: #333;


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renuka142 Unnecessary spacing.

margin: auto;
}
.pt-section-gold {
border-top: 1px solid #efbe00;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renuka142 Unnecessary spacing.

@Cronus1007
Copy link
Member

@renuka142 The PR seems good. Have a look upon the required changes.

@renuka142
Copy link
Contributor Author

Hello @Cronus1007 , sure i will do the above changes.
Thankyou for your remarks!

@Cronus1007
Copy link
Member

Cronus1007 commented Feb 14, 2021

@renuka142 Have a look about this ss. The unnecessary spacing between these two cards.
Screenshot from 2021-02-14 14-58-20

@renuka142
Copy link
Contributor Author

Okay , the two cards needs to be aligned.

@brylie brylie self-assigned this Oct 4, 2021
@brylie brylie merged commit 835a745 into creativecommons:main Oct 4, 2021
@TimidRobot
Copy link
Member

Deployed to production via salt-prime__core__us-east-2.

Preview command:

sudo salt \*misc\* state.apply user.admins,nginx.misc saltenv=${USER} test=True

(I then removed test=True to apply previewed changes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Overflow in Divs
4 participants