-
-
Notifications
You must be signed in to change notification settings - Fork 28
Resolving the text overflow in Divs ( "What comes after implementation" and "About" section) #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/src/css/style.css
Outdated
@@ -167,6 +168,8 @@ a.scroll-link:hover { | |||
border-bottom: none; | |||
background: #ffffff; | |||
color: #333; | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renuka142 Unnecessary spacing.
docs/src/css/style.css
Outdated
margin: auto; | ||
} | ||
.pt-section-gold { | ||
border-top: 1px solid #efbe00; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renuka142 Unnecessary spacing.
@renuka142 The PR seems good. Have a look upon the required changes. |
Hello @Cronus1007 , sure i will do the above changes. |
@renuka142 Have a look about this ss. The unnecessary spacing between these two cards. |
Okay , the two cards needs to be aligned. |
Deployed to production via Preview command:
(I then removed |
Fixes
fixes #76 by @shubhanshu02
Description
The PR resolves the text overflow occuring in the Div section i.e
When viewed on devices with a width between 768px to around 1300px.
Technical Details
changed some hardcoded widths and heights from these cards , for the pt-card and pt-text-card classes:
Tests
Screenshot
Developer Certificate of Origin
Developer Certificate of Origin