Skip to content

[Feature] Integrate Python Logging into Codebase for Improved Management #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
naishasinha opened this issue Mar 16, 2024 · 6 comments · Fixed by #97 or #96
Closed
1 task done

[Feature] Integrate Python Logging into Codebase for Improved Management #85

naishasinha opened this issue Mar 16, 2024 · 6 comments · Fixed by #97 or #96
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing feature help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work

Comments

@naishasinha
Copy link
Member

Problem

The current codebase relies on simplistic print() statements for debugging purposes, resulting in limited visibility, traceability, and debugging capabilities. As we expand the codebase for Quantifying the Commons, this approach will hamper our ability to effectively manage and diagnose issues for a much larger system, leading to inefficiencies in development, troubleshooting, and maintenance processes.

Description

Integrate Python logging into the codebase to improve logging capabilities. Python's logging module provides advanced features such as log levels, log formatting, logging to files, and integration with external logging systems. By implementing Python logging, we can enhance the maintainability, readability, and debugging experience of the codebase.

Alternatives

Another alternative is to use third-party logging libraries instead of Python's built-in logging module. However, although some third-party libraries do offer additional features and customization options, they may introduce dependencies and compatibility issues. This is why using Python's logging module would be a better option for this codebase.

Implementation

  • I would be interested in implementing this feature.
@naishasinha naishasinha added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Mar 16, 2024
@IamMQaisar
Copy link
Contributor

I would love to work on this feature, when confirmed, can @TimidRobot you assign me this?

@TimidRobot
Copy link
Member

Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and PRs.

We generally don't assign issues prior to resolution. Instead of asking for issues to be assigned, do the work and submit a pull request (PR). Even if multiple people submit PRs for the same issue, multiple ideas and implementations strengthen the final product.

For work program applicants, each can all list their own PRs on their application. It is the quality of work that is important, not whether it is merged.

@TimidRobot
Copy link
Member

TimidRobot commented Mar 16, 2024

Also see creativecommons/ccos-scripts for examples of logging with scripts and libraries

@TimidRobot TimidRobot added help wanted Open to participation from the community 🏁 status: ready for work Ready for work 🤖 aspect: dx Concerns developers' experience with the codebase and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Mar 16, 2024
@naishasinha
Copy link
Member Author

Also see creativecommons/ccos-scripts for examples of logging with scripts and libraries

Would you prefer I do it how it's done in this repository to keep consistency?

@TimidRobot
Copy link
Member

Also see creativecommons/ccos-scripts for examples of logging with scripts and libraries

Would you prefer I do it how it's done in this repository to keep consistency?

Not necessarily, but the way it's done there encapsulates a lot of trial and error regarding logging from loaded modules. This project doesn't have shared modules, yet, but I expect that to change. I would focus on creating the simplest solution for the current codebase with the addition of being able to log from a shared module.

I created an issue to create a shared library:

@naishasinha
Copy link
Member Author

Not necessarily, but the way it's done there encapsulates a lot of trial and error regarding logging from loaded modules. This project doesn't have shared modules, yet, but I expect that to change. I would focus on creating the simplest solution for the current codebase with the addition of being able to log from a shared module.

Sounds good, I will keep that in mind when implementing it!

I created an issue to create a shared library:

I will also work towards issue #91 as soon as I'm done with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing feature help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🏁 status: ready for work Ready for work
Projects
None yet
3 participants