-
-
Notifications
You must be signed in to change notification settings - Fork 38
Added installation guide for windows #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Windows pipenv installation guide added
Update README.md
@annatuma @Shafiya-Heena pls review it |
updated link formatting
@@ -10,7 +10,7 @@ public domain. Below are the sources and their respective information: | |||
tool paths. | |||
|
|||
**API documentation link:** | |||
- [`google_custom_search/legal-tool-paths.txt`][tools-paths]: a list of all | |||
- [Tools-paths][tools-paths]: a list of all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change reduces the information communicated 👎🏻
1. Run windows Powershell as administrator | ||
2. Run the following command | ||
``` | ||
pip install pipenv | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contradicts the pipenv documentation. If you think this method is best, please provide additional references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the items were sorted (Windows should be last)
Fixes
Fixes #46 and
fixes #47by @satyampsoni[Bug] Link formatting #47Description
The changes made adds the installation guide for windows as earlier it was only for Linux and MacOs.
Technical details
Added Pipenv guidelines for windows
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin