Skip to content

Added installation guide for windows #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

satyampsoni
Copy link

@satyampsoni satyampsoni commented Mar 25, 2023

Fixes

Fixes #46 and fixes #47 by @satyampsoni

Description

The changes made adds the installation guide for windows as earlier it was only for Linux and MacOs.

Technical details

Added Pipenv guidelines for windows

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • [] My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Windows pipenv installation guide added
@satyampsoni satyampsoni requested review from a team as code owners March 25, 2023 14:11
@satyampsoni satyampsoni requested review from annatuma and Shafiya-Heena and removed request for a team March 25, 2023 14:11
@satyampsoni
Copy link
Author

@annatuma @Shafiya-Heena pls review it

@@ -10,7 +10,7 @@ public domain. Below are the sources and their respective information:
tool paths.

**API documentation link:**
- [`google_custom_search/legal-tool-paths.txt`][tools-paths]: a list of all
- [Tools-paths][tools-paths]: a list of all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change reduces the information communicated 👎🏻

Comment on lines +40 to +44
1. Run windows Powershell as administrator
2. Run the following command
```
pip install pipenv
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contradicts the pipenv documentation. If you think this method is best, please provide additional references.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the items were sorted (Windows should be last)

@TimidRobot TimidRobot mentioned this pull request Mar 31, 2023
7 tasks
@TimidRobot TimidRobot self-assigned this Oct 26, 2023
@TimidRobot TimidRobot added the ⛔️ status: discarded Will not be worked on label Oct 26, 2023
@TimidRobot TimidRobot closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ status: discarded Will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Link formatting [Feature] pipenv guide for windows
2 participants