Skip to content

Use pre-commit CI to automatically fix code style issues #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

nox1134
Copy link
Contributor

@nox1134 nox1134 commented Mar 10, 2024

Fixes

Fixes #68 by @Darylgolden cc: @TimidRobot

Description

This PR adds a .pre-commit-config.yaml in order to run the pre-commit hook on the CI for automatically fixing code style issues.
In order to use this pre-commit CI, the project owner would need to enable it from the github-marketplace (https://github.com/marketplace/pre-commit-ci).

Technical details

I have few questions regarding the implementation:

  1. Do we also need to add pre-commit hooks for checking yaml, trailing whitespaces etc? (Not mentioned in the issue however i suggest to enable it)
  2. We can have two approaches: 1) Using (pre-commit ci) or 2) adding pre-commit hook in the github actions workflow to run pre-commit after every PR (I am following the 1st approach suggested in the issue, is this what was intented?)

Screenshots

image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

nox1134 added 2 commits March 11, 2024 02:23
Signed-off-by: Priyanshi Gaur <noxdot1134@gmail.com>
Signed-off-by: Priyanshi Gaur <noxdot1134@gmail.com>
@nox1134 nox1134 requested review from a team as code owners March 10, 2024 21:24
@nox1134 nox1134 requested review from TimidRobot and annatuma and removed request for a team March 10, 2024 21:24
@nox1134
Copy link
Contributor Author

nox1134 commented Mar 12, 2024

Hey @TimidRobot, What do you think of the above questions?

nox1134 added 2 commits March 13, 2024 03:33
…yaml

Signed-off-by: Priyanshi Gaur <noxdot1134@gmail.com>
Signed-off-by: Priyanshi Gaur <noxdot1134@gmail.com>
@nox1134
Copy link
Contributor Author

nox1134 commented Mar 12, 2024

I have updated the static analysis section in the README to include the steps for setting up pre-commit

image

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!!--just a few of requested changes

@TimidRobot TimidRobot self-assigned this Mar 13, 2024
…ly fail

Signed-off-by: Priyanshi Gaur <noxdot1134@gmail.com>
@nox1134
Copy link
Contributor Author

nox1134 commented Mar 13, 2024

Below is the README.md file after correcting the indentation:
image

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pre-commit CI to automatically fix code style issues
2 participants