Skip to content

Conversation

@SumaiyaaRq
Copy link
Contributor

Fixes

Description

This PR resolves the bug related to inconsistent HTML structure opposed to the expected structure mentioned in Vocabulary Documentation.
Present structure: body>header>main
Expected structure: body>main>header

Technical details

1.At first ,the HTML structure has been changed in the file 'index.html'.
2.Consequently, some CSS related issues occurred in the 'explore-panel' and the heading region of the page that lead to poor display.
3.To solve these issues,I have made changes in two files- 'style.css' & 'vocabulary.css' respectively.

Tests

1.One can check out the index.html file to find out the changed structure.
To see that the search portal looks like before:
1.Open the search portal.
2.View the explore panel .
3.Also see the heading region.

Screenshots

After correcting only the HTML structure the page looked like this.

Screenshot 2024-10-10 at 8 12 34 PM Screenshot 2024-10-10 at 9 21 59 PM

After making changes to CSS:

Screenshot 2024-10-10 at 8 55 53 PM

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@SumaiyaaRq SumaiyaaRq requested a review from a team as a code owner October 10, 2024 16:05
@SumaiyaaRq SumaiyaaRq requested review from Shafiya-Heena and TimidRobot and removed request for a team October 10, 2024 16:05
@netlify
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for cc-search-portal ready!

Name Link
🔨 Latest commit 87400c3
🔍 Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/6707fb4320ce2c0008389fab
😎 Deploy Preview https://deploy-preview-287--cc-search-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SumaiyaaRq SumaiyaaRq changed the title Bug: Inconsistent HTML structure in search portal BugFix: changed the HTML structure for search portal to match the expected structure Oct 11, 2024
@SumaiyaaRq SumaiyaaRq changed the title BugFix: changed the HTML structure for search portal to match the expected structure BugFix: Changed the HTML structure for search portal to match the expected structure Oct 11, 2024
@possumbilities
Copy link
Contributor

See comment on

After reviewing #287 and investigating further I believe this Issue was approved in error.

I think there might be a misunderstanding about the nature of this sturcture. There are two header elements present on most pages utilizing Vocabulary.

There is the Header - Global Area, and there is the Page Header - Region itself. Each of these relies on placement within a different context.

I'm closing this Issue and the related PR as the structure does in fact seem to reflect the correct implementation at this time.

Closing

@SumaiyaaRq
Copy link
Contributor Author

@possumbilities Thank you for reviewing and letting me know the reason behind closing the issue, I appreciate !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Bug] Inconsistent HTML Structure in Search Portal

2 participants