Skip to content

Conversation

@TimidRobot
Copy link
Member

@TimidRobot TimidRobot commented Dec 13, 2019

Description

Fixes dependencies within letsencrypt and letsencrypt.cloudflare states.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository.
  • My commit messages follow best practices.
  • I added tests for the changes I made (if applicable).
  • N/A I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@TimidRobot TimidRobot requested a review from a team as a code owner December 13, 2019 20:05
@TimidRobot TimidRobot self-assigned this Dec 13, 2019
@TimidRobot TimidRobot changed the title Fixes dependencies within letsencrypt.cloudflare state (both internal… Fixes dependencies within letsencrypt states Dec 13, 2019
@TimidRobot TimidRobot changed the title Fixes dependencies within letsencrypt states Fixes dependencies within letsencrypt states and upgrade to 1.0.0 Dec 13, 2019
Copy link

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving it to @TimidRobot , since they're the expert on this one, but I'm curious about best practices for handling dependencies in a case like this. Is there a way to specify which 'dot' of release to take?

@TimidRobot TimidRobot merged commit f34fce3 into master Dec 16, 2019
@TimidRobot TimidRobot deleted the letsencrypt-cloudflare-fixes branch December 16, 2019 17:02
@TimidRobot
Copy link
Member Author

@mathemancer The changes primarily impact SaltStack state dependencies (the changes to require and require_in). See Requisites and Other Global State Arguments.

For the Python dependencies of certbot and certbot-dns-cloudflare, the added upgrade: True means that they will be upgraded to the most recent version. A lot of people preferred pinned versions--but I think I'd rather commit to addressing problems as they arise than risk a deployment configuration that is left behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants