-
-
Notifications
You must be signed in to change notification settings - Fork 78
fixed nav Issue313 by adding angler > bracket #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vocabulary-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @rahulptl165 Same thing with this PR. It should be labelled as Here is the link to the contribution guidelines, Contribution guidelines |
|
@rahulptl165 You've added some whitespace changes unrelated to this PR, please remove them when you have a moment. Additionally, from @egbadon-victor 's comment, please don't move forward on PRs until Issues have moved to the correct status. |
|
Hi @egbadon-victor , Thank you for the clarification! I’ll review the contributor guidelines thoroughly and focus on issues labeled Status: Ready for work or help wanted. I’ll avoid issues marked Status: ticket work required for now. Thanks again for the guidance! |
|
Hi @possumbilities, Thank you for pointing that out! I’ve removed the unnecessary whitespace changes and updated the PR. Please let me know if there’s anything else that needs attention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Approved.
Fixes
Description
The opening
<nav>tag in the code was missing its closing angle bracket (>), which caused improper rendering of the navigation section. This fix ensures that the<nav>tag is properly closed, allowing the navigation content to render as intended.Technical details
Issue: The
<nav>tag was not properly closed, which caused the rendering issue.Fix: Added the missing closing angle bracket (>) to the opening
<nav>tagTests
The navigation section now renders correctly on the page.
No other elements are impacted by this change.
I manually verified the fix by inspecting the HTML output in the browser.
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin