Skip to content

Conversation

@rahulptl165
Copy link
Contributor

Fixes

Description

The opening <nav> tag in the code was missing its closing angle bracket (>), which caused improper rendering of the navigation section. This fix ensures that the <nav> tag is properly closed, allowing the navigation content to render as intended.

Technical details

Issue: The <nav> tag was not properly closed, which caused the rendering issue.
Fix: Added the missing closing angle bracket (>) to the opening <nav> tag

Tests

The navigation section now renders correctly on the page.
No other elements are impacted by this change.
I manually verified the fix by inspecting the HTML output in the browser.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@rahulptl165 rahulptl165 requested review from a team as code owners November 8, 2024 18:01
@rahulptl165 rahulptl165 requested review from Dhruvi16, Shafiya-Heena, TimidRobot, nimishbongale and possumbilities and removed request for a team November 8, 2024 18:01
@netlify
Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for vocabulary-docs ready!

Name Link
🔨 Latest commit a173676
🔍 Latest deploy log https://app.netlify.com/sites/vocabulary-docs/deploys/67335ec74589ad0008f56142
😎 Deploy Preview https://deploy-preview-315--vocabulary-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@egbadon-victor
Copy link
Contributor

Hi @rahulptl165

Same thing with this PR. It should be labelled as Status:ready for work or help wanted before you can submit a PR for the issue.

Here is the link to the contribution guidelines, Contribution guidelines

@possumbilities
Copy link
Contributor

possumbilities commented Nov 11, 2024

@rahulptl165 You've added some whitespace changes unrelated to this PR, please remove them when you have a moment.

Additionally, from @egbadon-victor 's comment, please don't move forward on PRs until Issues have moved to the correct status.

@rahulptl165
Copy link
Contributor Author

Hi @egbadon-victor , Thank you for the clarification! I’ll review the contributor guidelines thoroughly and focus on issues labeled Status: Ready for work or help wanted. I’ll avoid issues marked Status: ticket work required for now.

Thanks again for the guidance!

@rahulptl165
Copy link
Contributor Author

Hi @possumbilities, Thank you for pointing that out! I’ve removed the unnecessary whitespace changes and updated the PR. Please let me know if there’s anything else that needs attention.

Copy link
Contributor

@possumbilities possumbilities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Bug: Unclosed opening <nav> tag in person-page.html file

3 participants