Skip to content

Source order failing test #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2015
Merged

Source order failing test #2

merged 4 commits into from
May 31, 2015

Conversation

geelen
Copy link
Member

@geelen geelen commented May 31, 2015

Just thought I'd start a PR with the test-case to be getting on with.

@geelen
Copy link
Member Author

geelen commented May 31, 2015

Broke out a traceKeySorter and passing a string key format through dependencies. Means evaluation can happen as soon as files are present, but the order of insertion (which is the important part) can be determined after-the-fact. It works!

geelen added a commit that referenced this pull request May 31, 2015
@geelen
Merge pull request #2 from css-modules/source-order-failing-test
e94a1fb 
Source order failing test
@geelen geelen merged commit e94a1fb into master May 31, 2015
@geelen geelen deleted the source-order-failing-test branch May 31, 2015 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geelen