Skip to content

Enable transforming of files in node_modules #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2015

Conversation

joshwnj
Copy link
Member

@joshwnj joshwnj commented Aug 3, 2015

If we want to require css from something in node_modules we need to use the global: true transform option (https://github.com/substack/node-browserify/#btransformtr-opts)

Example: the import-node-module case will fail by default, and will pass if we set transform options of { global: true }

@joshwnj
Copy link
Member Author

joshwnj commented Aug 3, 2015

Btw this doesn't cover if you want to composes: foo from "cool-styles/styles.css". I've got it mostly working locally but will wait for this one to merge before I add it.

joshgillies added a commit that referenced this pull request Aug 3, 2015
Enable transforming of files in node_modules
@joshgillies joshgillies merged commit 077b1bf into master Aug 3, 2015
@joshgillies
Copy link
Member

Solid! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants